Submission Details
Severity:
BuyPresent function execution doesn't match function description
Summary
Anyone can buy a present for a user as opposed to the intended functionality
Vulnerability Details
/*
* @notice Buy a present for someone else. This should only be callable by someone who is naughty.
* @dev You'll first need to approve the SantasList contract to spend your SantaTokens.
*/
function buyPresent(address presentReceiver) external {
i_santaToken.burn(presentReceiver);
_mintAndIncrement();
}
In the buy present function above, there is no logic to ensure that the function can be called by a naughty user only as stated in the developer notice above
Tools Used
Manual Review
Recommendations
Add the following line of code to the buyPresent function
if (s_theListCheckedOnce[msg.sender] == Status.NAUGHTY || s_theListCheckedTwice[msg.sender] == Status.NAUGHTY) revert \* define custom error *\;
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.