Submission Details
Severity:
checkList function missing onlySanta modifier
Summary
checkList function missing onlySanta modifier that not meet the requirement "Only callable by santa".
Vulnerability Details
As it's described, this function should be only called by santa but it missing any caller check.
/*
* @notice Do a first pass on someone if they are naughty or nice.
* Only callable by santa
*
* @param person The person to check
* @param status The status of the person
*/
// add someone to checklist with status
// @audit missing onlySanta modifier
function checkList(address person, Status status) external {
s_theListCheckedOnce[person] = status;
emit CheckedOnce(person, status);
}
Impact
Any one can set person and status to s_theListCheckedOnce mapping.
Tools Used
Manual Review
Recommendations
Add onlySanta modifier
function checkList(address person, Status status) external onlySanta {
s_theListCheckedOnce[person] = status;
emit CheckedOnce(person, status);
}
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Access Control on checkList()
Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.