`SantasList::checkList()` lacks validation of caller
Summary
According to documentation SantasList::checkList() should be only callable by santa, but the function lacks checking if the msg.sender is the santa.
Vulnerability Details
Anyone can modify the SantasList::s_theListCheckedOnce and set arbitrary Status for arbitrary address.
Impact
High, this is likely to happen. Also this impact the functionality of contract by disallowing user to collectPresent if eligible, by an evil actor by modifying the s_theListCheckedOnce for the claimant.
Tools Used
Manual review
Recommendations
Lead Judging Commences
Access Control on checkList()
Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.