Submission Details
Severity:
No Access control on checkList
Summary
According to Doc checkList should be call by onlySanta but have not apply any access control so any one call it
Vulnerability Details
No access control on function lead to unwanted people in list , with Santa know about it and assign what every status they want
Impact
anyone can call it and be the part of list .
Tools Used
Manual
Recommendations
Used access modifier onlySanta
/*
* @notice Do a first pass on someone if they are naughty or nice.
* Only callable by santa
*
* @param person The person to check
* @param status The status of the person
*/
// @audit-info no access control anyone can enter in the check list but according to the doc onlySanta is allow
function checkList(address person, Status status) external onlySanta{
s_theListCheckedOnce[person] = status;
emit CheckedOnce(person, status);
}
Updates
Lead Judging Commences
equious
over 1 year ago
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Access Control on checkList()
Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.