Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Valid

Wrong amount on buyPresent

Summary

According to the documentation when some one buyPresent, it should have 2e18 of SantaToken , but in buyPresent when we burn coin it will burn only 1e18 which half coin as define in doc.

Vulnerability Details

buyPresent: A function that trades 2e18 of SantaToken for an NFT. This function can be called by anyone.

when someone buy present we lose money which is not good for business.

Impact

Get Present in half prices

Tools Used

manual

Recommendations

change burn into 2e18 or change price in doc

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Price is not enforced in buyPresent

This line indicates that the intended cost of presents for naughty people should be 2e18: https://github.com/Cyfrin/2023-11-Santas-List/blob/6627a6387adab89ae2ba2e82b38296723261c08a/src/SantasList.sol#L87 PURCHASE_PRESENT_COST should be implemented to enforce the cost of presents.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.