Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Unrestricted Access in `checkList` Function

Vulnerability Details

The checkList function, intended for exclusive access by Santa, lacks necessary access controls.

/*
* @notice Do a first pass on someone if they are naughty or nice.
* Only callable by santa //@audit no access control
*
* @param person The person to check
* @param status The status of the person
*/
function checkList(address person, Status status) external {
s_theListCheckedOnce[person] = status;
emit CheckedOnce(person, status);
}

Impact

  1. Unauthorized Access: Any user can call the function and modifying data meant to be modified only by Santa.

  2. Data Integrity Risk: The lack of access control jeopardizes the integrity of s_theListCheckedOnce.

Recommendations

Implement Access Control: Introduce a modifier to restrict function access to Santa.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Access Control on checkList()

Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.