Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

checkList whout access check

Summary

Anyone can change the s_theListCheckedOnce calling checkList(address,Status) setting any user's address to NAUGHTY blocking them from retrieving the gift.

Vulnerability Details

function checkList(address person, Status status) can be called by anyone that want to change a person's status.
If an attacker want to prevent a specific user to claim his gift he can call checkList with a status of NAUGHTY.

Impact

Any user can be blocked from claiming his gift.

Recommendations

Add the modifier onlySanta to the checkList function to allow only to Santa to change the list.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Access Control on checkList()

Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.