Submission Details
Severity:
Buy Gift with other's money
Vulnerability Details
The function buyPresent burn the tokens of the presentReceiver instead the caller's tokens and mint the gift for the caller.
This means that anyone can steal other users' tokens to claim gift for himself
Impact
An attacker can claim gift burning other users' tokens.
Recommendations
Burn the token of the msg.sender and mint the token to the presentReceiver, modifying the function like this:
function buyPresent(address presentReceiver) external {
i_santaToken.burn(msg.sender);
_safeMint(presentReceiver, s_tokenCounter++);
}
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
buyPresent should use msg.sender
Current implementation allows a malicious actor to burn someone else's tokens as the burn function doesn't actually check for approvals.
buyPresent should send to presentReceiver
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.