Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

checkList Modifier

Summary

checkList() is missing the onlySanta modifier

Vulnerability Details

Anyone can call the first checkList and set the status to any value for any address, s_theListCheckedOnce mapping.

Impact

Attacker can reset the status of all participants before the cutoff block and no one would get presents since the NICE status need to be equivalent in both s_theListCheckedOnce and s_theListCheckedTwice.

Tools Used

Remix/Foundry

Recommendations

Apply onlySanta modifier to checkList function.

Updates

Lead Judging Commences

inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

Access Control on checkList()

Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.