Submission Details
Severity:
Gas optimization in collectPresent
Optimization Details
This is a GAS.
If we assume that Santa will not change his mind after he decided an address state we can remove the check on s_theListCheckedOnce from the collectPresent() function
Recommendations
Change this: if (s_theListCheckedOnce[msg.sender] == Status.NICE && s_theListCheckedTwice[msg.sender] == Status.NICE)
in: if (s_theListCheckedTwice[msg.sender] == Status.NICE)
And change this:
} else if (
s_theListCheckedOnce[msg.sender] == Status.EXTRA_NICE
&& s_theListCheckedTwice[msg.sender] == Status.EXTRA_NICE
) {
in
} else if (s_theListCheckedTwice[msg.sender] == Status.EXTRA_NICE) {
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.