Submission Details
Severity:
Restrictive Status Update in `checkTwice` Function
Vulnerability Details
The checkTwice function is overly restrictive, only allowing Santa to set a user's status on the second list (s_theListCheckedTwice) to be identical to their status on the first list (s_theListCheckedOnce). This limitation prevents Santa from elevating a user's status from NICE to EXTRA_NICE if the user's status on the first list is NICE.
function checkTwice(address person, Status status) external onlySanta {
if (s_theListCheckedOnce[person] != status) {
revert SantasList__SecondCheckDoesntMatchFirst();
}
s_theListCheckedTwice[person] = status;
emit CheckedTwice(person, status);
}
Impact
Limited Flexibility: Santa cannot adjust a user's status.
Recommendations
Modify Check Logic: Allow Santa to elevate a user's status on the second list regardless of their status on the first list, or only if their status on the first list is NICE.
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.