Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Missing modifier in check in the checkList function

Summary

s_theCheckListOnce is a state variable that should only be updated by santa himself but due to missing modifier, any user or attacker can call the function and update the state. Attacker/user can then proceed to collect present

Vulnerability Details

Access control

Impact

Missing modifier allows set their s_theCheckListOnce status buy themselves and claim present

Tools Used

foundry, manual review

Recommendations

should add the onlysanta modfier

Updates

Lead Judging Commences

inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

Access Control on checkList()

Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.