Submission Details
Severity:
Present is being bought at cheaper price
Summary
As stated by the doc, the cost of Present should the 2e18 worth of tokens but user will end of paying 1e18 worth of token for the nft
Vulnerability Details
logic error
Impact
user can buy present at cheaper price
Tools Used
foundry
Recommendations
Price should be updated to 2eth in the mint function.
Updates
Lead Judging Commences
inallhonesty almost 2 years ago
Submission Judgement Published Assigned finding tags:
Price is not enforced in buyPresent
This line indicates that the intended cost of presents for naughty people should be 2e18: https://github.com/Cyfrin/2023-11-Santas-List/blob/6627a6387adab89ae2ba2e82b38296723261c08a/src/SantasList.sol#L87 PURCHASE_PRESENT_COST should be implemented to enforce the cost of presents.
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.