Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

```SantaList::CHRISTMAS_2023_BLOCK_TIME``` wrong date

Summary

The SantaList::CHRISTMAS_2023_BLOCK_TIME variable does not align with the actual Christmas date. This variable is crucial for initiating the collection of presents for both NICE and EXTRA_NICE users.

Vulnerability Details

@> uint256 public constant CHRISTMAS_2023_BLOCK_TIME = 1_703_480_381; //line 86

Impact

The SantaList::CHRISTMAS_2023_BLOCK_TIME variable does not align with the actual Christmas date.

Using an online Epoch & Unix Timestamp Conversion Tools (https://www.epochconverter.com/) we can convert epoch to human-readable date and vice versa:

CHRISTMAS_2023_BLOCK_TIME = 1703480381 = Dec, 25th 2023 04:59:41

Christmas Date starts at = 1703462400 = Dec, 25th 2023 00:00:00

So theNICE and EXTRA_NICE users can't collect his/her present from Dec, 25th 2023 00:00:00 but only from Dec, 25th 2023 04:59:41 (after 5 hours).

Tools Used

Manual review.

Recommendations

Adjust the SantaList::CHRISTMAS_2023_BLOCK_TIME with the right value.

- uint256 public constant CHRISTMAS_2023_BLOCK_TIME = 1_703_480_381;
+ uint256 public constant CHRISTMAS_2023_BLOCK_TIME = 1_703_462_400;
Updates

Lead Judging Commences

inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.