Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Pass collectPresent checks

Summary

Initial value of the s_theListCheckedOnce and s_theListCheckedTwice for an address is NICE

Vulnerability Details

All the addreses that are not changed with the checkList and checkTwice are 'NICE', therefore the persons that are not marked by Santa otherwise will pass the check from line 154

Impact

High

Tools Used

Manual

Recommendations

When defining the enum, the first should be Naughty

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

default status is nice

In Solidity the first element of an enum is the default value. In Santa's List, the means each person is mapped by default to 'NICE'.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.