Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

M1: Missing onlySanta modifier on "checkList" function

Summary

The "checkList" function can be called by any address and can change the value for any other address, including their own.

Vulnerability Details

The "checkList" function is missing the "onlySanta" modifier, and allows any sender to change the values in the "s_theListCheckedOnce" mapping.

Impact

High potential of tampering the values for any user, potentially causing inability to collect the presents for users.

Tools Used

Static analysis

Recommendations

Add "onlySanta" modifier to the "checkList" function.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Access Control on checkList()

Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.