Submission Details
Severity:
Constant variable `SantasList::PURCHASED_PRESENT_COST` not used
Summary
Constant variable SantasList::PURCHASED_PRESENT_COST not used
Vulnerability Details
Constant variable SantasList::PURCHASED_PRESENT_COST was suppose to be used as the token cost to buy a present, but it was not taken into account.
Impact
LOW.
Tools Used
Manual Review
Recommendations
Either delete the constant or implement it in the code
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
Price is not enforced in buyPresent
This line indicates that the intended cost of presents for naughty people should be 2e18: https://github.com/Cyfrin/2023-11-Santas-List/blob/6627a6387adab89ae2ba2e82b38296723261c08a/src/SantasList.sol#L87 PURCHASE_PRESENT_COST should be implemented to enforce the cost of presents.
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.