`SantasList::checkTwice` can be executed before `SantasList::checkTwice`
Summary
SantasList::checkTwice can be executed before SantasList::checkTwice
Vulnerability Details
If Santa calls SantasList::checkTwice with a NICE status for a user, this transaction will pass, although SantasList::checkList was never called before.
SantasList::checkTwice validates if SantasList::s_theListCheckedOnce mapping has the same status that is given in the function execution. But the default value in the mappings is NICE.
Impact
MEDIUM as the function can only be called by Santa anyways.
Tools Used
Manual Review
Recommendations
Update the default value of the enum Status from NICE to NAUGHTY.
Lead Judging Commences
default status is nice
In Solidity the first element of an enum is the default value. In Santa's List, the means each person is mapped by default to 'NICE'.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.