Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Missing emitted events for important state changes

Summary

Missing events emissions for important state changes

Vulnerability Details

Both SantasList::collectPresent and SantasList::buyPresent are the 2 of the most important functions in the protocol and fail to emit an event to notify the off chain resources.

Impact

LOW as no contract logic is affected

Tools Used

  • Manual Review

Recommendations

Add missing events to the contract

event PresentCollected(address user, uint256 tokenId);
event PresentBought(address user, address receiver, uint256 tokenId);
Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.