Submission Details
Severity:
Default user status is NICE
Summary
If not set, user status is NICE
Vulnerability Details
Status is a struct
enum Status {
NICE,
EXTRA_NICE,
NAUGHTY,
NOT_CHECKED_TWICE
}
That has first or default value as NICE
In mappings
mapping(address person => Status naughtyOrNice) private s_theListCheckedOnce;
mapping(address person => Status naughtyOrNice) private s_theListCheckedTwice;
Status for persons if NICE if not set. So persons for whom status is not set can just call checkList and status checks will pass
Impact
Any person with unset status can mint NFT gift
Tools Used
Recommendations
Use NOT_CHECKED_TWICE as first enum element
Updates
Lead Judging Commences
inallhonesty over 1 year ago
Submission Judgement Published Assigned finding tags:
default status is nice
In Solidity the first element of an enum is the default value. In Santa's List, the means each person is mapped by default to 'NICE'.
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.