Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Missing onlySanta modifier

Summary

Anyone can set an address to be included in in the list to be considered for receiving the NFT gift.

Vulnerability Details

In the absence of the onlySanta modifier, Anyone can maliciously call the checkList function and set a user's address to be eligible for the NFT gift. There should be an onlySanta modifier attached to this function to guard against this.

Impact

The NFT gift will become open to undeserving users. Also, malicious users can deliberately call this function and alter the state of other users.

Tools Used

Manual

Recommendations

The onlySanta modifier should be appended to the checkList function. This ensures that only Santa can use this function to add deserving users to his list.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Access Control on checkList()

Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.