First Flight #5: Santa's List

Summary

Token metadata and images are stored online. While this practice is not against the ERC721 standard and might be a desired feature, it is not the usual practice and is not specified in the readme.

Vulnerability Details

Token metadata and images are stored online.

Impact

The impact on gas costs is relatively low, as Arbitrum is the target chain, amounting to about 0.0036 ETH at current prices. However, this approach impacts the flexibility and upgradability of the metadata/images. Additionally, retrieving large amounts of data from the blockchain can be slow and resource-intensive.

Tools Used

Manual review.

Recommendations

Consider using IPFS (InterPlanetary File System) for storing metadata and images, or specify in the readme that all metadata are stored on-chain.