Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

checkList function is callable by anyone

Summary

The checkList function in src/SantasList.sol is callable by anyone, when it should only be callable by santa.

Vulnerability Details

This could lead to service denial by the user since he can update status in s_theListCheckedOnce at will.

Impact

High - compromising the protocol's functionality

Tools Used

Manual Review

Recommendations

Add the onlySanta modifier to the function

Updates

Lead Judging Commences

inallhonesty Lead Judge about 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

Access Control on checkList()

Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!