Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Missing 'indexed' Fields in Events

Summary

The events CheckedOnce and CheckedTwice in the SantasList contract are missing the indexed keyword for their fields.

Vulnerability Details

The events should utilize the indexed keyword for fields that may be useful for off-chain tools parsing events. Indexing these fields helps in quick accessibility of the event data. In this case, the events CheckedOnce and CheckedTwice should consider using the indexed keyword for the fields person and status to improve the efficiency of off-chain tools.

Impact

The absence of the indexed keyword may not affect the on-chain functionality of the contract, but it could impact the efficiency of off-chain tools that parse these events. Indexing relevant fields helps in quicker data retrieval for certain queries.

Tools used

  • Manual review

Recommendations

Consider adding the indexed keyword to the relevant fields in the CheckedOnce and CheckedTwice events. For example:

event CheckedOnce(address indexed person, Status indexed status);
event CheckedTwice(address indexed person, Status indexed status);

This change can enhance the efficiency of off-chain tools that parse these events without significantly impacting on-chain gas costs unless the number of indexed fields exceeds three.

Updates

Lead Judging Commences

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.