Submission Details
Severity:
Missing event
Summary
SantasList::collectPresent and SantasList::buyPresent do not emit events.
Vulnerability Details
For proper off-chain monitoring, functions SantasList::collectPresent and SantasList::buyPresent should emit events.
Impact
For the lack of emission of events, claims of presents from and for other users cannot be viewed off-chain.
Tools Used
Remix IDE
Recommendations
Emit events for state-changing transactions:
+ event PresentCollected(address from);
function collectPresent() external {
if (block.timestamp < CHRISTMAS_2023_BLOCK_TIME) {
revert SantasList__NotChristmasYet();
}
if (balanceOf(msg.sender) > 0) {
revert SantasList__AlreadyCollected();
}
if (s_theListCheckedOnce[msg.sender] == Status.NICE && s_theListCheckedTwice[msg.sender] == Status.NICE) {
_mintAndIncrement();
+ emit PresentCollected(msg.sender);
return;
} else if (
s_theListCheckedOnce[msg.sender] == Status.EXTRA_NICE
&& s_theListCheckedTwice[msg.sender] == Status.EXTRA_NICE
) {
_mintAndIncrement();
i_santaToken.mint(msg.sender);
+ emit PresentCollected(msg.sender);
return;
}
revert SantasList__NotNice();
}
+ event PresentBought(address from, address to);
function buyPresent(address presentReceiver) external {
i_santaToken.burn(presentReceiver);
_mintAndIncrement();
+ emit PresentBought(msg.sender, presentReceiver);
}
Rewards breakdown
nSLOC
116This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.