PURCHASED_PRESENT_COST unused
Summary
There is a public constant defined in the contract called PURCHASED_PRESENT_COST.
Vulnerability Details
This variable is not used anywhere in the contract.
Impact
This is mainly because the logic which was initially thought is not used during the implementation.
Tools Used
manual code review
Recommendations
It's recommended to either remove this variable or use it in the buyPresent() function as described in the contest details page.
Lead Judging Commences
Price is not enforced in buyPresent
This line indicates that the intended cost of presents for naughty people should be 2e18: https://github.com/Cyfrin/2023-11-Santas-List/blob/6627a6387adab89ae2ba2e82b38296723261c08a/src/SantasList.sol#L87 PURCHASE_PRESENT_COST should be implemented to enforce the cost of presents.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.