Arbitrary user can update the s_theListCheckedOnce
array due to the missing access control. In the natspec of the protocol, it points out that there should be onlySanta
modifier for checkList
function.
In the checkList
function where the s_theListCheckedOnce
array is updated, there is no access control and anyone can update the value. An user can bypass the first validation easily.
The first validation is useless since anyone can update its value.
Manual Review
Add onlySanta
modifier in the checkList
function
Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.