Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Anyone can trigger`checkList` due to the missging validation

Summary

Arbitrary user can update the s_theListCheckedOnce array due to the missing access control. In the natspec of the protocol, it points out that there should be onlySanta modifier for checkList function.

Vulnerability Details

In the checkList function where the s_theListCheckedOnce array is updated, there is no access control and anyone can update the value. An user can bypass the first validation easily.

Impact

The first validation is useless since anyone can update its value.

Tools Used

Manual Review

Recommendations

Add onlySanta modifier in the checkList function

Updates

Lead Judging Commences

inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

Access Control on checkList()

Anyone is able to call checkList() changing the status of a provided address. This is not intended functionality and is meant to be callable by only Santa.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.