PURCHASED_PRESENT_COST mismatch with amount burned in buyPresent function
Summary
PURCHASED_PRESENT_COST equals 2e18, but it is not used in buyPresent function, where only 1e18 token is burned
Vulnerability Details
buyPresent function burned token amount is less than specified in PURCHASED_PRESENT_COST constant, and that constant is never used.
Impact
buyPresent function burned token amount is less than specified
Tools Used
Foundry
Recommendations
add a burn function in SantaToken to burn arbitrary amount, and pass in PURCHASED_PRESENT_COST amount to it.
Lead Judging Commences
Price is not enforced in buyPresent
This line indicates that the intended cost of presents for naughty people should be 2e18: https://github.com/Cyfrin/2023-11-Santas-List/blob/6627a6387adab89ae2ba2e82b38296723261c08a/src/SantasList.sol#L87 PURCHASE_PRESENT_COST should be implemented to enforce the cost of presents.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.