Submission Details
Severity:
Unnecessary fee update - bad accounting
Summary
deposit() function in Thunderloan.sol contract has an unnecessary update of the asset token's exchange rate. This will lead to incorrect exchange rates.
Vulnerability Details
This logic should, and already does, happen in the flashloan() function.
Impact
Users could either pay a fee that is too high or low due to arbitrary calls to deposit().
Tools Used
Manual inspection
Recommendations
Remove the lines listed in relevant links section
Updates
Lead Judging Commences
0xnevi almost 2 years ago
Submission Judgement Published Assigned finding tags:
can't redeem because of the update exchange rate
Rewards breakdown
nSLOC
387This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.