Beginner FriendlyFoundryDeFiOracle
100 EXP
View results
Submission Details
Severity: low
Valid

Event Maths (Upgraded)

Summary

Detect missing events for critical arithmetic parameters.

Vulnerability Details

Location:

ThunderLoanUpgraded.updateFlashLoanFee(uint256) (src/upgradedProtocol/ThunderLoanUpgraded.sol#251-256) should emit an event for:

  • s_flashLoanFee = newFee (src/upgradedProtocol/ThunderLoanUpgraded.sol#255)

Impact

Oracle Manipulation: The contract relies on an external oracle for price feeds. If the oracle is manipulated, it could affect the contract's functionality and potentially lead to loss of funds.

Tools Used

Audit Wizard (Slither)

Recommendations

Emit an event for critical parameter changes.

Updates

Lead Judging Commences

0xnevi Lead Judge almost 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

missing event emission updateFlashLoanFee

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.