First Flight #3: Thunder Loan

Summary

Vulnerability Details

In the ThunderLoan deposit function, the user's mintAmount includes the fee. When no one uses the flashloan function, users may not be able to redeem all their tokens, as the exchange rate continues to rise. If this behavior is intentional on the part of the author, it may be left as is.

Impact

Tools Used

Recommendations

To ensure the deposit function works consistently, you can implement a logic model where the fee is calculated before calling assetToken.mint. Then, assign mintAmount to the original amount plus the fee. This model will function reliably even when no one calls the flashloan function.