Submission Details
Severity:
Don't need to set s_balanceDuringFlashLoan to 0 in the constructor of MockFlashLoanReceiver
Summary
s_balanceDuringFlashLoan is initialized to 0 in the constructor of MockFlashLoanReceiver. This serves no purpose because the only function that is not a getter function (ie, executeOperation) immediately sets s_balanceDuringFlashLoan to the amount of tokens in the contract anyway
Vulnerability Details
s_balanceDuringFlashLoan is set in the constructor to 0:
s_balanceDuringFlashLoan = 0;
Impact
You are wasting gas and maybe opening up additional attack surface when you don't need to. Plus variables are initialized to 0 when a contract is deployed anyway.
Tools Used
Manual review
Recommendations
Remove this from the constructor of MockFlashLoanReceiver:
s_balanceDuringFlashLoan = 0;
Rewards breakdown
nSLOC
387This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.