First Flight #3: Thunder Loan

Summary

Miss emit event listener

Vulnerability Details

updateFlashLoanFee() does not emit an event, so it is difficult to track changes in the value of s_flashLoanFee off-chain.

Impact

Improper track of changes in s_flashLoanFee thus giving room for manipulations without notice

Tools Used

Slither and Manual

Recommendations

// Define the event
event FlashLoanFeeUpdated(uint256 newFee);

function updateFlashLoanFee(uint256 newFee) external onlyOwner {
if (newFee > s_feePrecision) {
revert ThunderLoan__BadNewFee();
}
s_flashLoanFee = newFee;

// Emit the event
emit FlashLoanFeeUpdated(newFee);

}