Submission Details
Severity:
state variable difference in the upgraded contract
Summary
In upgraded contracts it's important to take care of the storage collisions.
Vulnerability Details
The order of the storage variables are different compared to ThunderLoan.sol vs ThunderLoanUpgraded.sol. Following command can be used to check the storage layout
forge inspect src/protocol/ThunderLoan.sol:ThunderLoan storagelayout --pretty
Impact
When the upgraded contract is called wrong storage variable will be updated.
Tools Used
Manual code review
Foundry
Recommendations
Correct the order of state variables in the upgraded contract
Updates
Lead Judging Commences
0xnevi over 1 year ago
Submission Judgement Published Assigned finding tags:
storage collision on upgrade
Rewards breakdown
nSLOC
387This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.