Beginner FriendlyFoundryDeFiOracle
100 EXP
View results
Submission Details
Severity: medium
Valid

`Thunderloan::setAllowedToken` delete entry in mapping while not allowed will lock LP token.

Summary

If an IERC20 token is allowed then not allowed, the entry in the mapping will be deleted therefore make the redeem function for this token malfunction.

Vulnerability Details

modifier revertIfNotAllowedToken(IERC20 token) {
if (!isAllowedToken(token)) {
revert ThunderLoan__NotAllowedToken(token);
}
_;
}

this modifier will always revert in the function redeem so the underlying token will be trapped.

Impact

LP will loose their underlying token

Tools Used

read the code

Recommendations

Have a different mechanism to check allow and not allow token.

Updates

Lead Judging Commences

0xnevi Lead Judge
over 1 year ago
0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Admin Input/call validation
0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

centralized owners can brick redemptions by unallowing a token

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.