Summary

Reduce contract gas usage

Vulnerability Details

Checking if an address is zero is best done with assembly as this is way more safe and efficient than compoaring with addres(0)

Impact

excessive gas usage can rendered protocol useless

Tools Used

manual

Recommendations

replace line with the following assembly code

  bool isZero;
    assembly {
        mstore(0, 0x00)
        isZero := eq(someAddress, mload(0))
    }
    if (isZero) { // @audit - assembly can be used to reduce gas fee
        revert AssetToken__ZeroAddress();
    }