First Flight #3: Thunder Loan

Summary: Fee is wrongly calculated, as the result is divided by 1e18, getting a value far away from the correct one.

Vulnerability Details: Fee for making a flash loan will be considerately lower than it should be.

Impact: High impact, the collected fee will practically become 0.

Tools Used

Recommendations: In function getCalculatedFee(IERC20 token, uint256 amount), the line 248 is

uint256 valueOfBorrowedToken = (amount * getPriceInWeth(address(token))) / s_feePrecision;

and it should be replaced with

uint256 valueOfBorrowedToken = amount * getPriceInWeth(address(token));

as it is divided by the s_feePrecision after in the function.