Submission Details
Severity:
Contracts storage layout can be corrupted on upgradeable contracts
Summary
Vulnerability Details
In the new ThunderLoanUpgraded, the storage layout can become corrupted. 's_feePrecision' has been removed and is now a constant. Constant variables do not occupy storage slots. Therefore, in the new layout, 's_flashLoanFee' will occupy the place of 's_feePrecision,' and 's_currentlyFlashLoaning' will take the place of 's_flashLoanFee.
Impact
Tools Used
Recommendations
Consider checking whether there were changes in the storage layout before upgrading a contract by saving the storage layout of the implementation contract’s previous version and comparing it with the storage layout of the new one.
Updates
Lead Judging Commences
0xnevi over 1 year ago
Submission Judgement Published Assigned finding tags:
storage collision on upgrade
Rewards breakdown
nSLOC
387This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.