Beginner FriendlyFoundryDeFiOracle
100 EXP
View results
Submission Details
Severity: medium
Invalid

Centralization risk for privileged functions

Summary

The owner is a single point of failure and a centralization risk
There are 2 instances of this issue

Vulnerability Details

Having a single EOA as the only owner of contracts is a large centralization risk and a single point of failure. A single private key may be taken in a hack, or the sole holder of the key may become unable to retrieve the key when necessary.

https://cwe.mitre.org/data/definitions/654.html

Impact

File: src/protocol/ThunderLoan.sol
253: function updateFlashLoanFee(uint256 newFee) external onlyOwner {
File: src/upgradedProtocol/ThunderLoanUpgraded.sol
251: function updateFlashLoanFee(uint256 newFee) external onlyOwner {

Tools Used

Manual review-

Recommendations

Consider changing to a multi-signature setup, or having a role-based authorization model.

Updates

Lead Judging Commences

0xnevi Lead Judge
over 1 year ago
0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Admin Input/call validation

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.