Submission Details
Severity:
Data type discrepancy between v1 and v2
Summary
S_feePrecision is differing in the two contract versions
Vulnerability Details
Changing variables is unsafe practice.
Ln 96 in ThunderLoan.sol (v1) : uint256 private s_feePrecision;
Ln 97 in ThunderLoan.sol(v2) : uint256 public constant FEE_PRECISION = 1e18;
Notice the difference (private vs public constant)
Impact
Low impact, but could open up to exploits potentially
Tools Used
Manual inspection
Recommendations
Make the variables match
Rewards breakdown
nSLOC
387This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.