Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Valid

Low and Non-Critical Findings

[L-01] Unused State Variable

Summary

The variable DISALLOWED is declared but never used.

Recommendation

Remove it from the codebase.

[L-02] Deployment of VotingBooth Will Fail on Arbitrum Because of Incompatibility Solidity Version 0.8.23

Summary

According to Arbitrum docs regarding the PUSH0 opcode:

This OPCODE is not yet supported, but will soon be available. This means that solidity version 0.8.20 or higher can only be used with an evm-version lower than the default shanghai (see instructions here to change that parameter in solc, or here to set the solidity or evmVersion configuration parameters in hardhat). Versions up to 0.8.19 (included) are fully compatible.

This mean that the deployment of the VotingBooth will fail.

Recommendations:

Lower the pragma version to 0.8.19.

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

PUSH0 not supported for solidity solidity ^0.8.20

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.