Contract will lock/burn Eth upon vote completion
Summary
If there are any votes against the proposal, a corresponding amount of the totalRewards will be locked/burned forever.
Vulnerability Details
The rewardPerVoter is calculated based on the totalVotes (which includes both votes for and against the proposal), but the rewards are only distributed to the voters who voted for the proposal (s_votersFor).
If there are any votes against the proposal, the total rewards will not be perfectly divisible by the number of votes for the proposal,
Impact
The fraction of totalVotesAgainst / totalVotes is the fraction of the totalRewards that will be locked/burned forever.
Tools Used
Recommendations
This could potentially be improved by calculating the rewardPerVoter based on the totalVotesFor instead of totalVotes
Lead Judging Commences
VotingBooth._distributeRewards(): Incorrect computation of rewardPerVoter
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.