First Flight #6: Voting Booth

Summary

The contract stipulates that the rewards will only be shared between those who voted For and not between all the voters.

Vulnerability Details

diff
function _distributeRewards() private {
     uint256 totalVotesFor = s_votersFor.length;
     uint256 totalVotesAgainst = s_votersAgainst.length;
     uint256 totalVotes = totalVotesFor + totalVotesAgainst;

    uint256 totalRewards = address(this).balance;
    if (totalVotesAgainst >= totalVotesFor) {
        _sendEth(s_creator, totalRewards);
    }
    else {
-     uint256 rewardPerVoter = totalRewards / totalVotes;

• uint256 rewardPerVoter = totalRewards / totalVotesFor;
  
     for (uint256 i; i < totalVotesFor; ++i) {
         if (i == totalVotesFor - 1) {
  

-             rewardPerVoter = Math.mulDiv(totalRewards, 1, totalVotes, Math.Rounding.Ceil);

•         rewardPerVoter = Math.mulDiv(totalRewards, 1, totalVotesFor, Math.Rounding.Ceil);
         }
         _sendEth(s_votersFor[i], rewardPerVoter);
     }
  

  }
  }