Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

inconsistent muldiv

Summary

discrete math on one line, math.muldiv on another

Vulnerability Details

the muldiv operation is performed twice in the contract, but in one case (line 156) it is discrete inline operators, and in another (line 207), the OZ Math.mulDiv is used.

Impact

none.

Tools Used

reading the code

Recommendations

make consistent use of mulDiv is we're going to include it in the library. either that, or add some parenthesis to enforce order of operations.

Updates

Lead Judging Commences

0xnevi Lead Judge
over 1 year ago
0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.