Submission Details
Severity:
``VotingBoot::_distributeRewards`` sends funds based on the totalVoters not totalVotersFor ,leads to wrong calculations
Summary
VotingBoot::_distributeRewards sends funds based on the totalVoters not totalVotersFor ,leads to wrong calculations
Vulnerability Details
uint256 rewardPerVoter = totalRewards / totalVotes;
Impact
the rewards according to the natspec documentation are meant to be distributed amongst the voters for not the total voters
as seen in the VotingBoot::_distributeRewards function
uint256 rewardPerVoter = totalRewards / totalVotes;
Tools Used
manual review
Recommendations
- uint256 rewardPerVoter = totalRewards / totalVotes
+ uint256 rewardPerVoter = totalRewards / totalVotesFor
Updates
Lead Judging Commences
0xnevi over 1 year ago
Submission Judgement Published Assigned finding tags:
VotingBooth._distributeRewards(): Incorrect computation of rewardPerVoter
Rewards breakdown
This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.