Submission Details
Severity:
rewardPerVoter is miscalulated
Summary
// otherwise the proposal passed so distribute rewards to the `For` voters
When reaching quorum and the proposal passes, the reward amount is calculated on the number of totalVotes instead of the number of forVoters.
Vulnerability Details
The miscalculation leads to part of the reward being stuck in the contract.
Impact
Eth stuck in contract.
Tools Used
Manual review.
Recommendations
rewardPerVoter should take into account the totalVotesFor and be careful with rounding issues.
Updates
Lead Judging Commences
0xnevi over 1 year ago
Submission Judgement Published Assigned finding tags:
VotingBooth._distributeRewards(): Incorrect computation of rewardPerVoter
Rewards breakdown
This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.