Wrong calculation for rewardPerVoter because we are using totalVotes instead we should use totalVotesFor
only as rewards will only distributed to for
voter .
It is mentioned if proposal passed so distribute rewards to the For
voters. If we include totalVotesAgainst
in calculating reward to per for
voter reward will not be accurate and some residue eth will be left in contract as there is no way to withdraw left balance.
If s_creator
deployed contract with 5 addresses
and 1 ether
. .
Only three of them VOTED
But for reward distribution loop running on totalVotesFor
only
that will distribute 0.333..
to 2 player leaving 0.333... eth stuck in contract.
Manual review
To fix this, we should only user totalVotesFor
only and we can evenly distribute reward without any residue.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.