Submission Details
Severity:
function _distributeRewards() doesn't distribute rewards correctly
Summary
When it comes to distributing rewards to voters the code doesn't work as intended
Vulnerability Details
rewardPerVoter is calculated by uint256 rewardPerVoter = totalRewards / totalVotes; and rewardPerVoter = Math.mulDiv(totalRewards, 1, totalVotes, Math.Rounding.Ceil); where instead of calculating for totalVotes it should be calculating for totalVotesFor
Impact
Leads to funds being stuck in the protocol
Tools Used
manual review
Recommendations
Replace totalVotes with totalVotesFor in the calculations
Updates
Lead Judging Commences
0xnevi over 1 year ago
Submission Judgement Published Assigned finding tags:
VotingBooth._distributeRewards(): Incorrect computation of rewardPerVoter
Rewards breakdown
This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.