stake.link

Summary

There are no limits enforced when setting maxLockingDuration and maxBoost in LinearBoostController

Vulnerability Details

Although maxLockingDuration is stored as uint64 in storage(a theoretical limit) still it can be set to a very large number as the max value a uint64 can hold is 18,446,744,073,709,551,615 which in days is 213,503,982,334,601. I highly doubt anyone will want to lock SDL for that long. Same goes for the maxBoost variable.

Impact

maxLockingDuration and maxBoost can both be set to a very large number

Tools Used

Manual Review

Recommendations

Set a reasonable cap to these variables to prevent them being initialized to extremely large numbers.