Submission Details
Severity:
SDLPoolCCIPControllerPrimary::Storage can be saved
Summary
Multiple mappings in SDLPoolCCIPController contract can be set as struct.
Vulnerability Details
In SDLPoolCCIPController.sol contract multiple mappings were initiated:
uint64[] internal whitelistedChains;
mapping(uint64 => address) public whitelistedDestinations;
mapping(uint64 => bytes) public updateExtraArgsByChain;
mapping(uint64 => bytes) public rewardsExtraArgsByChain;
mapping(uint64 => uint256) public reSDLSupplyByChain;
Reading and writing from & in it is gas expensive and it will increase deployment cost also.
Impact
Current implementation structure will cost more deployment cost and those are gas expensive while reading from it.
Tools Used
Manual analysis.
Recommendations
These can be set in struct & we can set the struct in an array. Like this:
Struct WhitelistedChain {
uint64 chainSelector;
address whitelistedDestination;
bytes updateExtraArgsByChain;
bytes rewardsExtraArgsByChain;
uint256 reSDLSupplyByChain;
}
WhitelistedChain[] internal whitelistedChains;
Prize pool breakdown
Total prize
27,500 USDC
nSLOC
1,41419 USDC / LOC
25,000 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.